odbc_exec

morten at nilsen dot com (2008-05-16 05:50:01)

Regarding the query-building for collecting large forms, this would be better:

<?php
  foreach($_POST as &$v)
    $v = str_replace("'", '', $v);

  $sql = 'INSERT INTO table (' . join(',',array_keys($_POST)) . ') VALUES (' . join(',', array_fill(0, count($_POST), '?')) . ')';
  $query = odbc_prepare($conn, $sql);
  $result = odbc_execute($query, $_POST);
?>

mir eder (2007-08-28 03:39:22)

If you are having problems with truncated text fields from ODBC queries (pe. at 4096 characters), try some of the following:
in php.ini:
- odbc.defaultlrl = 65536
in your php code, before your queries:
- ini_set ( 'odbc.defaultlrl' , '65536' );

bslorence (2006-12-07 12:38:01)

A determined attacker will easily jump through whatever string-escaping hoops you can devise. A better way to protect yourself against SQL injection is to bind your parameters, which requires calling odbc_prepare() and odbc_execute():

<?php
$emp_id = $_GET['emp_id'];
$stmt = odbc_prepare($db_conn, "SELECT pwd FROM employees WHERE emp_id=?");
$res = odbc_execute($stmt, array($emp_id));
?>

This should compile the SELECT statement so that the parameter 'emp_id' is never included as part of your literal SQL query; i.e., it prevents your end users from "contributing" to your code.

But of course even the above is not good enough; see particularly the warning about single-quote-delimited strings in odbc_execute()'s parameters array:

http://www.php.net/manual/en/function.odbc-execute.php

It's paramount that you validate user-supplied parameters, always and everywhere -- and keep in mind that every query-variable from a GET or POST should be considered "user-supplied", even if it's in a hidden input field on the front-end web page and the average browser user has no control over it.

Take the above example, and suppose that the backend database uses a two-byte unsigned numeric field to store 'emp_id'.

In that case, then you must make sure, before you do anything with ODBC, that 'emp_id' is indeed numeric, positive, and <= 65535. If it's not, assume an attack and fail with an ambiguous error message.

If you trust user input without checking it yourself, you're asking to be hacked.

Here's a nice intro to SQL-injection:

http://www.unixwiz.net/techtips/sql-injection.html

delowing gmail dot com (2006-09-27 20:19:33)

It is easy to inject evil code into SQL statements. This wraps parameters in quotes so they are not executable. In your own stored procedures you can convert the string to numeric as needed.
function sql_make_string($sin){
return "'".str_replace("'","''",$sin)."'";
}
// this may delete all data from MYTABLE
$evil = "734'; DELETE FROM MYTABLE; print 'ha ha";
$sql = "SELECT * FROM MYTABLE WHERE mykey = '$evil'";
$rst = odbc_exec($connection,$sql);
// this probably will not delete the data.
$good = sql_make_string($evil);
$sql = "SELECT * FROM MYTABLE WHERE mykey =".$good
$rst = odbc_exec($connection,$sql);

denis at i39 dot ru (2006-08-24 05:24:18)

I've got an error on MS SQL Server 2000, when tryed to execute query which grants rights to user to connect to database:

<?
$Query = "
 EXEC sp_grantdbaccess ".$_REQUEST['user'].";
 EXEC sp_addrolemember  'db_owner','".$_REQUEST['user']."';
            ";
        if (!@odbc_exec($db_Conn, $Query))
            $strErrorMessage = odbc_errormsg($db_Conn);
?>

The result was: Executing SQL directly; no cursor.

This query executes fine in MS's sql console. So it seems that problem is in odbc driver.
I've found desicion by removing first "EXEC".

It looks:
<?
$Query = "
 sp_grantdbaccess ".$_REQUEST['user'].";
 EXEC sp_addrolemember  'db_owner','".$_REQUEST['user']."';
            ";
        if (!@odbc_exec($db_Conn, $Query))
            $strErrorMessage = odbc_errormsg($db_Conn);

?>

P.S. Don't remove the second 'exec', 'cos MS returns another error :)

(2006-05-30 17:02:25)

Wouldn't it be better to use the database itself to find out if an id doesn't exist. eg: SELECT COUNT(id) as idCount FROM [Table] WHERE id = [ID]
Then check if idCount is zero or not.

joex444 at gmail dot com (2005-09-21 14:14:18)

Maybe not the best way, but here's how I find out if a row doesn't exist:
$row=odbc_fetch_array($result);
$id=$row['id'];
if($id=="") {
//no rows
} else {
//rows
}
Where the 'id' field is a required field in your table...

(2005-08-30 06:18:49)

The following seems counterintuitive to me and so I am constantly getting burned by it. Just thought I'd add a note for anyone else who might also get burned.
if (!odbc_exec("select MyValue from MyTable where Key1='x' and Key2='y'"))
is not a good way to search for the existence of a record with Key1 = x and Key2 = y. The odbc_exec always returns a result handle, even though there aren't any records.
Rather, you must use one of the fetch functions to find out that the record really doesn't exist. This should work:
if (!($Selhand = odbc_exec("select MyValue from MyTable where Key1='x' and Key2='y'"))
|| !odbc_result($Selhand, 1))

fuadMD at gmail dot com (2005-05-24 00:34:40)

<?php
// - This is a complete working dynamic example of using: 
//    odbc_connect, odbc_exec, getting col Names,
//    odbc_fetch_row and no of rows. hope it helps
// - your driver should point to your MS access file

$conn = odbc_connect('MSAccessDriver','',''); 

$nrows=0; 

if ($conn)
{
$sql =  "select * from $month"; 
//this function will execute the sql satament
$result=odbc_exec($conn, $sql);

echo "<table  align=\"center\" border=\"1\" borderColor=\"\" cellpadding=\"0\" cellspacing=\"0\">\n";
echo "<tr> ";
// -- print field name
$colName = odbc_num_fields($result);
for ($j=1; $j<= $colName; $j++)
{
echo "<th  align=\"left\" bgcolor=\"#CCCCCC\" > <font color=\"#990000\"> ";
echo odbc_field_name ($result, $j );
echo "</font> </th>";
}
$j=$j-1;
$c=0;
// end of field names
while(odbc_fetch_row($result)) // getting data
{
 $c=$c+1;
 if ( $c%2 == 0 ) 
 echo "<tr bgcolor=\"#d0d0d0\" >\n";
 else 
 echo "<tr bgcolor=\"#eeeeee\">\n";
    for($i=1;$i<=odbc_num_fields($result);$i++)
      {        
        echo "<td>";
        echo odbc_result($result,$i);
        echo "</td>";         
        if ( $i%$j == 0 )  
           {
            $nrows+=1; // counting no of rows    
          }   
      }
    echo "</tr>";
} 

echo "</td> </tr>\n";
echo "</table >\n";
// --end of table  
if ($nrows==0) echo "<br/><center> Nothing for $month yet! Try back later</center>  <br/>"; 
else echo "<br/><center> Total Records:  $nrows </center>  <br/>";
odbc_close ($conn);

}
else echo "odbc not connected <br>";
?>

james @ php-for-beginners co uk (2005-03-18 04:54:37)

hi all, I managed to get this little snippet working, it's pretty useful if you have long forms to be inserted into a database.
if ( ! empty ( $_POST ) ){
array_pop($_POST);
foreach($_POST as $key => $val){
$columns .= addslashes($key) . ", ";
$values .= "'" . addslashes($val) . "', ";

}
$values = substr_replace($values, "", -2);
$columns = substr_replace($columns, "", -2);

$sql = "INSERT INTO table ($columns) VALUES ($values)";
echo $sql;
$results = odbc_exec($conn, $sql);
if ($results){
echo "Query Executed";
}else {
echo "Query failed " .odbc_error();
}
}
Not the most secure in the world but, speeds up collecting data from large forms.

mramirez at star-dev dot com (2005-02-28 16:23:59)

Hi, I was trying to execute an stored procedure with
PHP 4.3.10 and MS SQL Server 6.5 using PHP function
"odbc_exec" and ODBC.

The problem was that it returned an ouput parameter
and didn't  know the right PHP functions and SQL
syntax to call it.

Finally after looking elsewhere, it worked this way:

<html>

<title>test.php</title>

<body>

<?php
  $server   = 'myservername';  
  $database = 'mydatabasename';
  $username = 'myusername';
  $password = 'mypassword';

  $connection_string =
   'DRIVER={SQL SERVER};SERVER=' . $server . ';DATABASE=' . $database;

  $connection = odbc_connect($connection_string, $username, $password);

  $sql  = "BEGIN ";
  $sql .= "  declare @MyOutputValue int ";
  $sql .= "  execute MyStoredProc @MyOutputValue output select @MyOutputValue ";
  $sql .= "END ";

  echo '<form>' . chr(13);
  echo '<table border="1">' . chr(13) . chr(13);
  echo '<tr>';
  echo '<td><b>Valor</b></td>';
  echo '</tr>';

  $query = odbc_exec($connection, $sql);

  while(odbc_fetch_row($query))
  {
     echo '<tr>' . chr(13);

     // "odbc_result" = "FieldByNumber(Index)",
     // "Index" starts with 1 not 0 !!! :
     $returnvalue = odbc_result($query, 1);

     echo '<td>' . $returnvalue . '</td>';
     echo '</tr>' . chr(13);
     echo chr(13);
  }

  echo '</table>' . chr(13);
  echo '</form>' . chr(13);

  odbc_free_result($query);

  odbc_close($connection);

?>

</body>

</html>

Good Luck.

Tom Cully <mail at tomcully dot com> (2005-02-28 08:22:29)

MS Access through ODBC doesn't just not like quotes (escape with '' - two single quotes), it also really hates newlines - chr(10)s - in LONGCHAR fields, and maybe in other BINARY based fields as well. Leave in a return character - chr(13) - to get a "new line" when working with LONGCHAR fields in ODBC/MS Access:
Here's a function to do both for you:
function odbc_access_escape_str($str) {
$out="";
for($a=0; $a<strlen($str); $a++) {
if($str[$a]=="'") {
$out.="''";
} else
if($str[$a]!=chr(10)) {
$out.=$str[$a];
}
}
return $out;
}

d dot soussan at sovereignls dot co dot uk (2005-01-16 08:19:22)

re the note from: sk2xml at gmx dot net 21-Nov-2001 02:15
About [] not working with Access.
if you use [] arount the field name then you must also use them around the table name, thus:
select [table1].[field1] from table1
That is standard Access syntax.
sk2xml's example had:
select table1.[field1] from table1
which will always fail.

sameer dot kelkar at gmail dot com (2004-08-31 03:26:49)

$callstore = odbc_exec($conn, "{CALL procedurename('" . $para1 . "','" . $para2 . "',1,'125478')}");
odbc_fetch_row($callstore);
$returnmessage = odbc_result($callstore,1);
echo $returnmessage;

victor dot kirk at serco dot com (2004-05-26 05:47:03)

rupix said above:
> it does not work. However if I use single quotes instead of \" the thing runs smoothly
SQL uses 'single quotes' to specify strings, thats why a \" does not work.

Sean Boulter (2004-04-21 17:50:45)

Update to my previous post... Another way to solve the problem with single quotes (at least in my environment (php 4.3.6, ODBC to MS Access db)), is to edit the php.ini file and set magic_quotes_gpc = On and magic_quotes_sybase = On. Note that this is a global setting, which may or may not be desirable.

Sean Boulter (2004-04-21 17:28:54)

If a single quote exists within the field specified by your WHERE statement, ODBC fails because of a parsing error. Although it seems intuitive, using \" around the field does not work (\"$var\"). The only solution I found was to replace all single quotes in my field with two single quotes. ODBC interprets the first single quote as an escape character and interprets the second single quote as a literal. Thanks to http://www.devguru.com/features/knowledge_base/A100206.html for this tip.

christopherbyrne at hotmail dot com (2004-01-23 01:33:16)

When you pass a parameter to an Access procedure all data types (seemingly) can be single quoted and dates do not need (and will not work when) surrounded by #'s.
Hope this helps!

rob at vendorpromotions dot com (2003-06-17 01:29:40)

This opens select statements 'for update' by default in db2. If you're using db2, you have to tack on 'for read only' at the end to select from SYSCAT.TABLES, for example, without firing an error like
Warning: SQL error: [IBM][CLI Driver][DB2/LINUX] SQL0151N The column "MAXFREESPACESEARCH" cannot be updated. SQLSTATE=42808 , SQL state 42808 in SQLExecDirect
For example :
$query = odbc_exec($conn, "select * from syscat.tables for read only");
odbc_result_all($query);
will work (only for db2). I don't know about other databases.
The select statement will work in the 'db2' command line, but not in php, because of this side effect.

rupix at rediffmail dot com (2003-04-05 07:05:35)

I tried the following line of code

<?php
$odbc=odbc_connect("pbk", "root","") or die(odbc_errormsg());
$q="insert into pbk values(\"$name\", \"$phone\")";
print $q;
odbc_exec($odbc, $q) or die("<p>".odbc_errormsg());
?>

it does not work. However if I use single quotes instead of \" the thing runs smoothly

thus the following would work

<?php
$odbc=odbc_connect("pbk", "yourworstnightmare","abracadabra") or die(odbc_errormsg());
$q="insert into pbk values('$name', '$phone')";
print $q;
odbc_exec($odbc, $q) or die("<p>".odbc_errormsg());
?>

Also having a user dsn is no good on win2k. Always have a System DSN. I don't know yet what are the implications of the same.

das_yrch at hotmail dot com (2003-03-07 03:17:14)

I tried this way to see the results of a query and it works!!
$Conn = odbc_connect
("bbdd_usuaris","","",SQL_CUR_USE_ODBC );
$result=odbc_exec($Conn,"select nom from usuaris;");
while(odbc_fetch_row($result)){
for($i=1;$i<=odbc_num_fields($result);$i++){
echo "Result is ".odbc_result($result,$i);
}
}

miguel dot erill at doymer dot com (2002-07-23 15:33:14)

In a previous contribution it was told that if you're running NT/IIS with PHP 3.0.11 you can use MS Access dbs "stored procedures".
That was right, but if those stores procedures have parameters you have to supply them in the command line like this:
$conn_id = odbc_connect( "odbc_test_db", "","", SQL_CUR_USE_DRIVER );
$qry_id = odbc_do( $conn_id, "{CALL MyQuery(".$param.")}" );

martin at NOSPAMkouba dot at (2002-02-05 08:37:00)

"[Microsoft][ODBC Microsoft Access Driver] Too few
parameters. Expected 1."
this not so clear to understand error comes when using access-odbc and a field name can't be found. check for correct spelling of fields.

lee200082 at hotmail dot com (2002-01-21 17:07:19)

As an addition to the note about square brackets earlier:
Enclosing sql field names in '[' and ']' also allows you to use MS Access reserved words like 'date' and 'field' and 'time' in your SQL query... it seems that the square brackets simply tell Access to ignore any other meaning whatever is inside them has and take them simply as field names.

sk2xml at gmx dot net (2001-11-21 06:15:49)

Problem: Fieldnames in SQL-Statement have blanks and [] don't work!
Solution: Try "" instead
Ex.:
SELECT table2.first, table1.[last name] FROM tabel1, table2 -> don't work
SELECT table2.first, table1.\"last name\" FROM tabel1, table2 -> Try this
PS: Don't forget the espace characters !!!

cfewer1 at home dot com (2001-08-15 02:25:15)

If you're receiving a 'Syntax error in INSERT INTO ..<snip>.. SQL State 37000 in SQLExecDirect' error, try enclosing the field names between square brackets.
ex:
INSERT INTO whatever ([blah],[who],[what]) VALUES ('blah','blah','blah');
I spent 4 hours tryin to get this insert statement (without the []'s) to work. This seems to have fixed it.
[]'s, apparently according to MS, should be used with table/field names with spaces. Im not sure if this is an MS ODBC thing, or a PHP flaw.
tested with: win32/php4.0.6/apache1.3.20/odbc/mdac2.6sp1

akchu at at ualberta dot ca (2001-01-07 20:41:02)

ODBC/MS Access Date Fields:
Matching dates in SELECT statements for MS Access requires the following format:
#Y-m-d H:i:s#
for example:
SELECT * FROM TableName WHERE Birthdate = #2001-01-07 00:00:00#
or
SELECT * FROM TableName WHERE Birthdate BETWEEN #2000-01-07 00:00:00# AND #2001-01-07 00:00:00#
This took me forever to figure out.

vpil at retico dot com (2000-11-06 06:24:07)

Additional links to ODBC_exec:
How to actually write the SQL commands:
http://www.roth.net/perl/odbc/faq/
http://www.netaxs.com/~joc/perl/article/SQL.html
Demystifying SQL
BIG REF MANUAL:
http://w3.one.net/~jhoffman/sqltut.htm
Introduction to Structured Query Language
Covers read, add, modify & delete of data.

phobo at at at paradise dot net dot nz (2000-11-02 06:26:32)

If Openlink -> MS Access Database fails and gives "Driver Not Capable" error or "No tuples available" warning, use the SQL_CUR_USE_ODBC cursor when using odbc_connect()...
Siggy

andreas dot brunner at rubner dot com (2000-07-07 16:54:19)

I wanted to access an MSAccess database via ODBC. The connection functioned without problems, but when I placed a SQL statement into my odbc_exec() i always got an error:
Warning: SQL error: [Microsoft][ODBC Driver Manager] Driver does not support that function, SQL state IM001 in SQLSetStmtOption in \\Server\directory/test.php3 on line 19.
Resolved my problem by myself: i simply had to install a new odbc-driver from the microsoft homepage.

gross at arkana dot de (1999-10-28 06:03:29)

If you're running NT/IIS with PHP 3.0.11 and want to use MS Access dbs with "stored procedures" you can send an ODBC SQL query like:
<?php
$conn_id = odbc_connect( "odbc_test_db", "", "", SQL_CUR_USE_DRIVER );
$qry_id = odbc_do( $conn_id, "{CALL MyQuery}" );
?>
This way you don't need to integrate query strings like 

SELECT * FROM TblObject WHERE (((TblObject.something) Like "blahblahblah"));

in the php file. You directly call the query "MyQuery" that was generated by MS Access.

rmkim at uwaterloo dot ca (1999-08-25 11:13:41)

for Win32(NT) and MSAcess 2000, whenever you retrieve a date column/field, php will automatically convert it to 'yyyy/mm/dd hh:mm:ss' format regardless of the style of date you've denoted in Access.
This seems to pose a problem when you exec SELECT, UPDATE, or DELETE queries, but strangley INSERT works fine. I've tried parsing the date into the desired format, but php still yells criteria mismatch.